Re-generating fact sets which were missing the mountpoints fact #210
+6,125
−1,015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
centos9/rh9/oracle9 still need to be re-done |
|
I only see updated factsets in your PR, did you tuned something to have these facts are is a previous change enabling them and they where just waiting to be "refreshed"? |
|
The facter gem needs the sys-filesystems gem in order to generate the mountpoints fact. However, the facter gem doesn't add it as a runtime dependency since the facter team didn't want to require folks to need a C compiler to use facter. An earlier PR (#206) added in the sys-filesystem gem, so going forward the mountpoints fact will get generated. This PR was to fix most of the earlier generated factsets to include the missing mountpoints fact. |
smortex
approved these changes
Nov 8, 2021
This was referenced Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.